Repository navigation
golden masters: LF on every OS (Windows autocrlf broke the canonical check) - #3410
Merged
Merged
Conversation
…check) On windows-latest the full-suite gate failed 3 golden_store tests: a Windows checkout's autocrlf rewrote all 204 parts of each split fixture to CRLF, so golden_store's byte-level canonical check rejected them. The real-merge test's scratch repo hit the same rewrite. The fixture directories are now 'text eol=lf', like refraction_snapshot, and the two scratch-repo tests set core.autocrlf=false. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On
windows-latest(3.9 and 3.12), the Full Suite Gate fails three tests added with the #3402 golden master split:test_committed_fixture_is_loadable_and_canonical[tests/golden_master_audit]test_committed_fixture_is_loadable_and_canonical[tests/golden_master_zero_dep_audit]test_real_git_merge_of_two_fact_channel_branches_is_conflict_freeWindows runners check out with
core.autocrlf=true, so git rewrote all 204 parts of each split fixture to CRLF, andgolden_store's byte-level canonical check rejected every one of them. The real-merge test's scratch repo has no.gitattributesand hit the same rewrite. Linux and macOS pass. The Windows matrix only runs on labelled PRs, so #3402's own CI never ran it. It surfaced on the matrix run I started by hand for #3407 (run 35908310402), which also confirms #3407's fix for the 32,767-character env-var error: those failures are gone.Fix
.gitattributes: both fixture directories are nowtext eol=lf, the same treatmenttests/cobol_mainframe/refraction_snapshot/**already gets. The existing-diff linguist-generated=truestays.tests/test_golden_store.py: the two scratch-repo tests setcore.autocrlf=false.Verification
git add --renormalizeon both directories changes nothing: every stored blob is already LF, so this doesn't touch the fixture contents.core.autocrlf=trueclone): 204 of 204 parts come out CRLF on current main, and 0 on this branch.tests/test_golden_store.py: 20 passed.ruff formatis clean.🤖 Generated with Claude Code