Repository navigation
feat: calls_out Phase 3 Batch 4 — C-family _calls_out_ignore tuning (#3286) - #3297
Merged
Merged
Conversation
perl (my/local/unless/elsif...), ruby, lua, matlab, ada (casefolded pragma/volatile/suppress), m4 (ifelse/ifdef control macros): per-language _calls_out_ignore frozensets + strict tests. No regex changes. Empties the dead-key baseline (writers ship here; also shipped in #3284/#3285). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts: # tests/dead_key_audit_baseline.json
squid-protocol
added
the
rosetta:rebless-owed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3286. Epic #3264 Phase 3, Batch 4 of 6. Needs #3288 + #3296 (both merged; main merged in).
What
No regex changes — six languages keep
CALLS_OUT_C_STYLEand gain a_calls_out_ignorefrozenset (lowercase, casefold-compared): perl (my/our/local/unless/elsif/…), ruby, lua, matlab, ada (pragma/volatile/suppress — thepragma Volatile (X)call-lookalikes), m4 (ifelse/ifdef control macros, ledgered as tolerated noise in the truth oracle). Real calls stay live (adaOpen/Read, luapcall/rawget, m4syscmd/esyscmd— deliberately NOT ignored). Strict tests assert trap-filtering and positive survival per language.Verification
verify_language.py: ruby/lua/matlab PASS unchanged; perl losesmy/elsifon all 13 nodes; ada loses Volatile/Suppress; m4 loses control-macro noise — all oracle-approved directionscheck_calls_out_truth.py: PASS on scratch-reblessed perl/ada/m4 manifests (run pre-rename; re-verified post-merge)🤖 Generated with Claude Code