fix(extraction): resolve unvalidated tri-comparison ledger shapes for Obj-C, Swift, Tcl, TS - #2224
Merged
Merged
Conversation
… Obj-C, Swift, Tcl, TS
This commit resolves a batch of unvalidated tri-comparison shapes by improving extraction accuracy:
- **Objective-C**: Updated `func_start` to correctly match unparenthesized return types (e.g., `- unsigned char next_input_block`).
- **Swift**: Modified `detector.py` normalizer to preserve standard operator characters (e.g., `==`), preventing them from collapsing into `Unknown_Block`.
- **Tcl**: Updated `func_start` to optionally consume the inline brace-wrapped argument list so it isn't mistaken for the function body by the balanced-brace finder.
- **TypeScript**: Fixed arrow function `func_start` branch to permit up to 3 levels of nested parentheses in the return type, enabling extraction of `const fn = <T>(): (returnType<...>) => {`.
Closes #2214
Closes #2217
Closes #2218
Closes #2220
Also updates all relevant baselines (Tree-sitter accuracy, Crucible Golden Masters, Tri-comparison Ledger/Chart).
squid-protocol
force-pushed
the
fix/tri-comparison-sweep-final-issues
branch
from
August 24, 2026 20:15
2d3ad00 to
8c513ef
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the manual validation sweep for the remaining unvalidated tri-comparison shapes, resulting in accuracy fixes for Objective-C, Swift, Tcl, and TypeScript.
Defect Fixes:
func_startto correctly match unparenthesized return types (e.g.,- unsigned char next_input_block).detector.pynormalizer to preserve standard operator characters (e.g.,==), preventing them from collapsing intoUnknown_Block.func_startto optionally consume the inline brace-wrapped argument list so it isn't mistaken for the function body by the balanced-brace finder.func_startbranch to permit up to 3 levels of nested parentheses in the return type, enabling extraction ofconst fn = <T>(): (returnType<...>) => {.Closed Issues
Closes #2214
Closes #2217
Closes #2218
Closes #2220
(Issues #2215, #2216, and #2219 were also investigated but closed as working-as-intended.)
Baseline Updates
tests/golden_master_audit.jsonandtests/golden_master_zero_dep_audit.jsonto reflect the recovered symbols and corresponding metrics shifts.tri_comparison_ledger.jsonand regenerated the SVG chart and markdown report.