Repository navigation
Validate css function/existence tri-comparison ledger shape - #2067
Merged
Merged
Conversation
The single css shape (agree[gitgalaxy,tree_sitter]_vs[ctags], function/ existence) is a confirmed ctags-side structural limitation, not a GitGalaxy defect. GitGalaxy's func_start regex and tree-sitter's CSS grammar agree exactly (3/3, zero diffs) that @media/@supports/etc. at-rules are the closest CSS analogue to a function, matching the existing #1313 convention; ctags has no function-equivalent concept for CSS at all (already documented as an empty FUNCTION_KIND_MAP entry in ctags_reader.py). No code fix needed, no credit/debit adjustment -- ctags simply has no comparable claim here. Regenerated the full chart so css shows a resolved badge instead of an asterisk. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
css/function/existence/agree[gitgalaxy,tree_sitter]_vs[ctags]): confirmed ctags-side limitation, not a GitGalaxy defect.func_startregex and tree-sitter's CSS grammar agree exactly on treating@media/@supports/@container/@layer/@keyframes/@-webkit-keyframesat-rules as function-shaped (CSS has no true function syntax) -- this matches the already-documented tree_sitter_accuracy_audit.py reports real_functions=0 for css/kotlin/powershell/zig despite confirmed function-shaped nodes in real corpus files #1313 convention. Re-rangather_language("css")against the full 4-file corpus directly (not just the ledger's capped sample): 3/3 functions match exactly, zero diffs.FUNCTION_KIND_MAP["css"] = set(), already documented inctags_reader.py), confirmed empty across all 4 corpus files.tri_comparison_chart.svg(--all --write); css now shows a resolved badge.Test plan
python tests/ruff_audit.py --ci-- clean (78-finding baseline, no new)python tests/mypy_audit.py --ci-- clean (2-error baseline, no new)last_reconciled_attimestamp churn from the regeneration🤖 Generated with Claude Code