chore: redesign PR template around actual CI gates, not vibes - #1203
Merged
Conversation
The old template asked every contributor to check "Visual Observatory Testing" and self-grade whether their change improved the engine's "Ethos" -- boilerplate that doesn't apply to most incoming PRs (docs, tooling, non-parsing fixes) and gives reviewers no real signal. Replace it with a conditional checklist that maps to what CI actually runs: audit_check.py (ruff/mypy/dead-key baselines + format), pytest, and crucible_check.py (Differential Scan) only when parsing/engine logic is touched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/tools/audit_check.py(ruff/mypy/dead-key baselines + format),pytest, andtests/tools/crucible_check.py(the Differential Scan) -- the last two only flagged as relevant when the PR touches parsing/engine logic or the output JSON schema.Verification
Rendered the new markdown locally and cross-checked every command/script referenced (
audit_check.py,crucible_check.py) against CLAUDE.md/CONTRIBUTING.md to confirm they're current and real.