You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
licensing.py: forgery-hammer message claims 'Incident has been flagged' but nothing is logged anywhere #486
The forgery-hammer message in enforce_licensing_guard() (gitgalaxy/licensing.py) says:
Incident has been flagged. Executing under maximum compliance friction.
There's no log write, no local file, no telemetry call anywhere in this function -- nothing persists anywhere. Given this project's Zero-Trust/no-data-transmission design elsewhere, that's consistent with intent (nothing should phone home), but the message actively claims something happened that didn't.
Impact
This is a "says one thing, does another" bug, not just a design tradeoff. A user hitting this path (e.g. a fat-fingered key, see #4-style issue) is told an incident was "flagged" somewhere, which isn't true and could be misleading about what data this tool does or doesn't collect/transmit.
Reproduction
Trigger the forgery-hammer branch in enforce_licensing_guard() (a key that parses correctly but fails RSA signature verification).
Read the printed message: "Incident has been flagged."
Observe: no file write, no log line, no network call anywhere in the function.
Suggested fix
Soften the copy to not claim persistence that doesn't happen -- e.g. state plainly that the check runs entirely offline and nothing is logged or transmitted, since that's the actual (and, per the project's design elsewhere, intentional) behavior.
Status
Fixed in #483 (bundled with the related malformed/forged key distinction). Filing for tracking since this was found during a manual review rather than starting from a filed issue.
Fixed by #483, merged as 2080ec1 on main. The forgery-hammer message now reads "This check runs entirely offline -- nothing is logged or transmitted anywhere" instead of the false "Incident has been flagged" claim. GitHub's auto-close via the PR's closing keywords didn't fire (likely a timing race between the PR description edit and the merge), closing manually.
Activity
squid-protocol commentedon Jul 26, 2026
Related: #487 (the malformed/forged key conflation this same forgery-hammer path has) -- both fixed together in #483.
squid-protocol commentedon Jul 26, 2026
Fixed by #483, merged as 2080ec1 on main. The forgery-hammer message now reads "This check runs entirely offline -- nothing is logged or transmitted anywhere" instead of the false "Incident has been flagged" claim. GitHub's auto-close via the PR's closing keywords didn't fire (likely a timing race between the PR description edit and the merge), closing manually.