Repository navigation
Handle array inputs and optional values in capacitance analysis - #96
davrens101 wants to merge 3 commits into
Conversation
|
I cherry-picked all seven SQDMetal fixes (#91-97) onto their shared upstream base and they apply cleanly together. The existing focused tests give 14 passed, 21 subtests passed (19 source/dependency/SciPy warnings, not suppressed). I also ran the 15 ordered three-mode EPR selections, 18 single-qubit capacitance configurations, three two-qubit input forms, single- and multi-port linewidths, and absent optional files directly, and they all work. No new permanent tests for #95-97, and I did not run the full suite or an external EM solver. |
| else: | ||
| Cres, Lres = 0, 0 | ||
| if num_conductors >= 5: | ||
| C_c = C_rf |
There was a problem hiding this comment.
Somewhat pointless even moving it here; either way, keep the comment # res-feedline mutual capacitance.
There was a problem hiding this comment.
Restored the # res-feedline mutual capacitance comment on C_c = C_rf in de3af06. The failing deploy check is the Sphinx docs deploy: it gets a 403 pushing to gh-pages from the fork PR, so it isn't caused by this change.
|
I can approve, once the small change has been made. |
|
Removed the redundant parentheses around res is not None. No behaviour change. |
The capacitance postprocessors document NumPy matrix input, but both call
.valuesand reject actual ndarrays. The single-qubit helper also crashes on documented optional configurations: omitted qubit frequency, or a four-conductor qubit/readout circuit without a feedline.np.asarrayin both one- and two-qubit entry points, retaining DataFrame/indexed-CSV support.f_q_GHz=Nonewhen no frequency was supplied, and document these cases.No circuit formula, optimizer, public signature or existing numeric-zero placeholder changes.
Verified before/after with real imports and temporary Palace-format CSVs, without mocks:
Review and assistance
I supervised and checked the AI-assisted work as it progressed. AI assistance was used for investigation, implementation and verification. No maintainer review or approval is claimed. Verification was CPU-only; no GPU validation is claimed.