Repository navigation
Fix redshifting of OpSpecs which return a blue result and drop red args - #766
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of #762: we need to take care of side effects even when the result is blue.
This happens in particular when we pass red-arguments-with-side-effects to a metafunc, and the resulting OpImpl drops them.
As a result, now
let(tup)is finally blue 🎉.On a side note: I think that #762 and this PR show the limits of the current AST-based doppler: the advantage is to make the life of the backends very easy, but the disadvantage is that we need the overall doppler logic start to be convoluted and a bit fragile.
I wonder whether we should lower to ANF before doppler, or possibly abandon AST interpretation and switch to a more classical bytecode interp.