Repository navigation
Conversation
paugier
force-pushed
the
backend_c-parens-avoiding-warnings
branch
from
October 12, 2026 12:23
340c1cd to
d38d559
Compare
paugier
changed the title
paugier
marked this pull request as ready for review
October 12, 2026 12:30
antocuni
reviewed
Oct 12, 2026
antocuni
left a comment
antocuni
left a comment
Member
There was a problem hiding this comment.
I just skimmed over the code and didn't look carefully.
But, can't we achieve the same effect by just tweaking the precendences in c_ast.BinOp._table?
Contributor
Author
|
I don't think we can achieve the same result by just tweaking c_ast.BinOp._table. However, we can use the data of this table to code the needed information in a much shorter way (but not very readable). I tried that in the last commit but I don't know what is better. |
5 of 17 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes from what I try to do with SIMD.
In a test in the CI
SPY_WERROR=1so warnings are turned into errors. Before these changes, expressions liken + 127 << 23triggered a gcc warning.I had to use AI to understand and produce the fix (but I tried to make it as clean as possible).