Skip to content

Stop registering internal RedisClient as bean#6563

Open
quaff wants to merge 1 commit into
spring-projects:mainfrom
quaff:patch-79
Open

Stop registering internal RedisClient as bean#6563
quaff wants to merge 1 commit into
spring-projects:mainfrom
quaff:patch-79

Conversation

@quaff

@quaff quaff commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Align chat-memory-repository-redis and vector-store-redis-semantic-cache with vector-store-redis, keep JedisClient isolated with each other module.

Align `chat-memory-repository-redis` and `vector-store-redis-semantic-cache` with `vector-store-redis`, keep `JedisClient` isolated with each other module.

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@quaff

quaff commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

/cc @sdeleuze

@sdeleuze sdeleuze self-assigned this Jul 6, 2026
@sdeleuze sdeleuze added the redis label Jul 6, 2026
@sdeleuze

sdeleuze commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@quaff Could you please share more context about this ask? Or is it only for consistency?

@quaff

quaff commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@quaff Could you please share more context about this ask? Or is it only for consistency?

Not only for consistency, chat-memory-repository-redis is using it's own host and port from spring.ai.chat.memory.repository.redis.*, its RedisClient presence may backoff vector-store-redis-semantic-cache's RedisClient which using host and port from spring.data.redis.*, it's unexpected behavior.

@quaff

quaff commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

I have a better solution: https://github.com/spring-projects/spring-ai/compare/main...quaff:spring-ai:patch-80?expand=1

Should I close this and create another one? @sdeleuze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants