Merged
Conversation
omercelikceng
commented
Aug 1, 2024
| } | ||
| } | ||
|
|
||
| @Test |
Contributor
Author
There was a problem hiding this comment.
If the development I made is not implemented, only this test fails. The other tests complete successfully.
Contributor
Author
|
@olegz, hello. Thank you very much for your interest. However, there are other situations where these headers are not set. If this target_protocol needs to be set in all cases, I will need to make further developments accordingly. Should I open another pull request to explain this better? Could you inform me about this? |
Contributor
|
Please do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
While working on a development related to Spring Cloud Stream, I noticed a situation that is also relevant to Spring Cloud Function.
To explain the issue clearly, we will first examine a method from Spring Cloud Function. The following method exhibits different behaviors. In some cases, it generates the output message using the input header, while in other cases, it does not consider the input header at all. This results in some variations in the code.
In other words, the code below can sometimes directly set the headers provided in the input to the output header. Sometimes, it creates the output headers without using the input headers.
Now, let's examine the method affected by the above code. I have written some tests, and based on the results, the target-protocol header is sometimes set and sometimes not. Therefore, I have made the relevant development.
However, I still have some questions that I do not fully understand. I would greatly appreciate your help. Is the target-protocol header a value that should be set for every message? If so, there are many places that we need to correct. Could you please provide me with information on this matter?
I am a bit confused, so I wanted to ask you before continuing with the development. Thank you.