Add start_link/1 function to GroupMemberSupervisor - #69
Closed
objectuser wants to merge 1 commit into
Closed
Conversation
This function is in support for the new supervisor child specs supported
in Elixir. This allows just the module to be provided as a child to the
parent supervisor.
```
def start(_type, _args) do
children = [
Kaffe.GroupMemberSupervisor
]
opts = [strategy: :one_for_all, name: MyApp.Supervisor]
Supervisor.start_link(children, opts)
end
```
|
@objectuser - Is this something that's still worth merging in? Are there any risks with backwards compatibility? |
Contributor
Author
|
@dtykocki I'm not sure why I didn't merge this in. I don't think there are any compatibility issues because it's additive. I do think the extra changes should be removed. |
|
That change can be merged to be updated with the Supervisor child specs? |
travismorrison
added a commit
that referenced
this pull request
Nov 16, 2021
- elixir version -> 1.12 - deprecated supervisor()/supervise()/worker() methods -> Supervisor.start_link() (in the spirit of #69) - redefined method docs -> comments - deprecated Mix.Config -> Elixir's Config implementation - deprecated :crypto.rand_uniform() -> :rand.uniform
travismorrison
added a commit
that referenced
this pull request
Nov 16, 2021
- elixir version -> 1.12 - deprecated supervisor()/supervise()/worker() methods -> Supervisor.start_link() (in the spirit of #69) - redefined method docs -> comments - deprecated Mix.Config -> Elixir's Config implementation - deprecated :crypto.rand_uniform() -> :rand.uniform
Contributor
|
Resolved by #131 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is in support for the new supervisor child specs supported
in Elixir. This allows just the module to be provided as a child to the
parent supervisor.