Skip to content

Benchmark fused comparison for all widths#129

Merged
AdamGS merged 2 commits intodevelopfrom
adamg/benchmark-fuze-compare-all-widths
Apr 23, 2026
Merged

Benchmark fused comparison for all widths#129
AdamGS merged 2 commits intodevelopfrom
adamg/benchmark-fuze-compare-all-widths

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented Apr 23, 2026

Enable fused comparison benchmarking, and run it for all widths

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Comment thread benches/bitpacking_cmp.rs

#[divan::bench(types=[u8, u16, u32, u64], consts = BENCH_W)]
fn bitpacking_cmp_fused<T, const W: usize>(bencher: Bencher)
const ALL_WIDTHS: [usize; 62] = [
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a divan limitations, if used in a const generic it can't be more than 20 items.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 23, 2026

Merging this PR will degrade performance by 18.72%

❌ 1 regressed benchmark
✅ 26 untouched benchmarks
🆕 120 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
pack_16_to_3_stack 1.8 µs 2.2 µs -18.72%
🆕 bitpacking_cmp_fused[u32, 16] N/A 3.6 µs N/A
🆕 bitpacking_cmp_fused[u32, 19] N/A 4 µs N/A
🆕 bitpacking_cmp_fused[u32, 18] N/A 3.9 µs N/A
🆕 bitpacking_cmp_fused[u32, 17] N/A 3.8 µs N/A
🆕 bitpacking_cmp_fused[u32, 20] N/A 4 µs N/A
🆕 bitpacking_cmp_fused[u32, 6] N/A 3.1 µs N/A
🆕 bitpacking_cmp_fused[u32, 3] N/A 2.8 µs N/A
🆕 bitpacking_cmp_fused[u32, 21] N/A 4.2 µs N/A
🆕 bitpacking_cmp_fused[u32, 30] N/A 4.8 µs N/A
🆕 bitpacking_cmp_fused[u16, 12] N/A 2.6 µs N/A
🆕 bitpacking_cmp_fused[u16, 11] N/A 2.6 µs N/A
🆕 bitpacking_cmp_fused[u16, 10] N/A 2.6 µs N/A
🆕 bitpacking_cmp_fused[u32, 22] N/A 4.2 µs N/A
🆕 bitpacking_cmp_fused[u32, 31] N/A 4 µs N/A
🆕 bitpacking_cmp_fused[u32, 24] N/A 4.2 µs N/A
🆕 bitpacking_cmp_fused[u16, 13] N/A 2.7 µs N/A
🆕 bitpacking_cmp_fused[u32, 4] N/A 2.8 µs N/A
🆕 bitpacking_cmp_fused[u16, 2] N/A 2.3 µs N/A
🆕 bitpacking_cmp_fused[u32, 5] N/A 3 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing adamg/benchmark-fuze-compare-all-widths (237049e) with develop (f6a7c0e)

Open in CodSpeed

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS changed the title Benchmark fuzed comparison for all widths Benchmark fused comparison for all widths Apr 23, 2026
@AdamGS AdamGS requested a review from robert3005 April 23, 2026 14:52
@AdamGS AdamGS marked this pull request as ready for review April 23, 2026 14:53
@AdamGS AdamGS merged commit 64f7aa9 into develop Apr 23, 2026
3 of 4 checks passed
@AdamGS AdamGS deleted the adamg/benchmark-fuze-compare-all-widths branch April 23, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants