Benchmark fused comparison for all widths#129
Merged
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
commented
Apr 23, 2026
|
|
||
| #[divan::bench(types=[u8, u16, u32, u64], consts = BENCH_W)] | ||
| fn bitpacking_cmp_fused<T, const W: usize>(bencher: Bencher) | ||
| const ALL_WIDTHS: [usize; 62] = [ |
Contributor
Author
There was a problem hiding this comment.
This is a divan limitations, if used in a const generic it can't be more than 20 items.
Merging this PR will degrade performance by 18.72%
Performance Changes
Comparing |
robert3005
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable fused comparison benchmarking, and run it for all widths