fix: config type check when loading any config - #2007
Merged
Merged
Conversation
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the config type check when loading configuration data by streamlining error handling and avoiding redundant configuration map creation.
- Updated ReadConfig and MergeConfig functions to load configuration into a local map and then apply it.
- Reorganized unmarshalReader to compute the config type prior to reading the input stream.
Comments suppressed due to low confidence (1)
viper.go:1673
- The call to buf.ReadFrom(in) does not check for errors, which may mask I/O issues during configuration loading. Consider capturing and handling the returned error from ReadFrom to ensure robust error handling.
buf.ReadFrom(in)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.