fix: report map string conversion errors - #364
Open
ryanchou1994 wants to merge 1 commit into
Open
ryanchou1994 wants to merge 1 commit into
ryanchou1994 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToStringMapStringE currently discards conversion errors from map keys and values. For example, a map value containing an unsupported slice returns an empty string with a nil error.
Return the first conversion error while continuing to build the complete result. ToStringMapString keeps its existing output, including zero values for entries that cannot be converted. Each key and value is converted once.
The regression tests cover invalid keys and values, mixed entries, named map types, JSON input, and Stringer call counts.
Validation: full shuffled race tests, go vet, and go build passed on Linux with Go 1.21.13 and 1.27.1; golangci-lint 2.13.1 reported no issues.
Related #159. This addresses missing error reporting; it does not add slice-to-JSON conversion.