fix: float string to number parsing - #276
Merged
Merged
Conversation
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
ccoVeille
reviewed
Jun 2, 2025
ccoVeille
left a comment
ccoVeille
left a comment
There was a problem hiding this comment.
I apparently forgot to press send ... 🤦♂️
Comment on lines
+537
to
+543
| // handle special cases | ||
| switch s { | ||
| case "-", "+": | ||
| s += "0" | ||
| case "": | ||
| s = "0" | ||
| } |
There was a problem hiding this comment.
You should explain these cases here, as it's not obvious
Suggested change
| // handle special cases | |
| switch s { | |
| case "-", "+": | |
| s += "0" | |
| case "": | |
| s = "0" | |
| } | |
| // handle special cases | |
| switch s { | |
| case "-", "+": // like -.25 or +.25 | |
| s += "0" | |
| case "": // like .25 | |
| s = "0" | |
| } |
chouetz
pushed a commit
to DataDog/cast
that referenced
this pull request
Apr 14, 2026
fix: float string to number parsing
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #274