Fix runtime admission and lifecycle; coordinate contract major 2 - #223
Merged
Merged
Conversation
davidalucas
marked this pull request as ready for review
September 29, 2026 08:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime now rejects invalid or over-capacity work before dispatch without retiring a healthy worker, and serializes lifecycle transitions so cancellation cannot abandon owned cleanup. Both independent SA products receive the fixes and contract major 2.
The public break corrects the three robot Machine ID parameters to collection/instrument identifiers with new field tags and reserved old tags. The change also corrects exact-target edit-text bindings, exposes Stopping and typed Overloaded outcomes, and removes obsolete restart bookkeeping.
Validation: 927 portable server/worker/protocol tests; strict protobuf migration and negative mutation checks; six updated client packages passed 72 fake-SDK conformance scenarios; all twelve retained published packages rejected the incompatible server before launch. The compatibility matrix preserves 60 historical pairs and adds these 18 records. Development CI tests both acceptance and rejection; releases require compatible published clients. No licensed SA testing or public package publication is claimed.
This is the correctness and compatibility stage of the approved redesign. Typed operations, private value/outcome contracts, domain organization, broader lifecycle ownership, and performance measurements are tracked in #221. Installer, documentation, and examples coordination continues in spatialanalyzer/briosa-installer#22, spatialanalyzer/briosa-docs#80, and spatialanalyzer/briosa-examples#9.
Refs #220
Refs spatialanalyzer/briosa-dotnet#35
Refs spatialanalyzer/briosa-js#36
Refs spatialanalyzer/briosa-py#35