Add gpu target to rocm packages -hipsolver, hipblas#4050
Add gpu target to rocm packages -hipsolver, hipblas#4050srekolam wants to merge 14 commits intospack:developfrom
Conversation
spackbot-triage
Bot
requested review from
afzpatel,
cgmb,
haampie and
renjithravindrankannath
|
@spackbot rerun pipeline |
|
I've started that pipeline for you! |
|
@alalazo , can you please review this PR and let me know if you have any comments |
|
@haampie , can you please review the PR. This is ready for merge |
srekolam
changed the title
|
some of the changes were merged as part of #4099 Updated the few remaining package to use gpu_targets. |
|
@tgamblin . can you please review this PR |
| ) | ||
| depends_on( | ||
| f"rocsolver@{ver} amdgpu_target={tgt}", when=f"+rocm @{ver} amdgpu_target={tgt}" | ||
| ) |
There was a problem hiding this comment.
Question: I'm curious why the target constraints were merged into this loop with the version constraints. It looks like there is an effective change (including "auto") but that could have been kept separate: were you seeing errors without doing this merge? The new logic looks correct also, but more complex than before.
There was a problem hiding this comment.
Some of the packages were building for all the amdgpu_targets and it was taking longer build time. Having them to specify amdgpu_target will reduce the build time. Hence this change.
4 participants
No description provided.