Installation issue: paraview

[Biebar]

Steps to reproduce the issue

Spack fails to build paraview on a compute node with no gpu.

$ spack install paraview @6 -qt -x -cuda +mpi +python +osmesa_fallback ^mesa -glx

Error message

Error message

[x] bwhug3k paraview@6.1.0 failed

1 error found in paraview@6.1.0 build log:
-- lines 172 to 184 --
  -- Could NOT find freetype (missing: freetype_DIR)
  -- Found Freetype: /home/criann/gbarbier/spack-test/spack/opt/spack/linux-zen4/freetype-2.14.2-wpvs6vkwu3sngrnchanm5rell2kfit5j/lib/libfreetype.so (found version "2.14.2")
  -- Found JsonCpp: /home/criann/gbarbier/spack-test/spack/opt/spack/linux-zen4/jsoncpp-1.9.6-3x7352t7edmbfa55xayry3yzv4zh6wqt/lib64/libjsoncpp.so (found suitable version "1.9.6", minimum required is "0.7.0")
  -- Found MPI_C: /home/criann/gbarbier/spack-test/spack/opt/spack/linux-zen4/openmpi-5.0.10-7icyhweofxbje4tunp55hgdftavphog6/lib/libmpi.so (found version "3.1")
  -- Found MPI: TRUE (found version "3.1") found components: C
  -- Could NOT find X11 (missing: X11_X11_INCLUDE_PATH X11_X11_LIB)
> CMake Error at VTK/CMake/vtkModule.cmake:5400 (message):
    Could not find the X11 external dependency.
  Call Stack (most recent call first):
    VTK/Utilities/X11/CMakeLists.txt:3 (vtk_module_find_package)


  -- Configuring incomplete, errors occurred!

Information on your system

• Spack: 1.2.0.dev0 (spack/spack@7e86478)
• Builtin repo: d060bd9
• Python: 3.9.21
• Platform: linux-rhel9-zen4

Additional information

It seems to me that in this spec, paraview depends on osmesa but not on gl. The package decides to define -DVTK_USE_X=OFF when the spec satisfies ^[virtuals=gl] osmesa which isn't the case.

spack-build-env.txt
spack-build-out.txt

maintainers: @danlipsa @kwryankrattiger @vicentebolea

General information

• I have run spack debug report and reported the version of Spack/Python/Platform
• I have run spack maintainers <name-of-the-package> and @mentioned any maintainers
• I have uploaded the build log and environment files
• I have searched the issues of this repo and believe this is not a duplicate

[kwryankrattiger]

This was a mistake in the conversion. ParaView 6 does not have a direct GL dependency anymore, it comes from the runtime environment now.

The fix here is to use the variant x to determine if X is enabled or not. For OSMesa I added an additional change. The flag is redundant for VTK rendering, however it is still used for IceT. I made this conditional on the osmesa_fallback variant.