[file_selector] Add support for getting multiple directories in macOS#68
Closed
VanesaOshiro wants to merge 1 commit into74323-add-get-directories-paths-platform-interfacefrom
Conversation
VanesaOshiro
force-pushed
the
66978-add-get-multiple-directories-in-macos
branch
from
0af035e to
bdb08aa
Compare
adpinola
reviewed
Oct 14, 2022
adpinola
reviewed
Oct 14, 2022
packages/file_selector/file_selector_macos/example/lib/main.dart
Outdated
Show resolved
Hide resolved
adpinola
reviewed
Oct 14, 2022
| } | ||
|
|
||
| @override | ||
| Future<List<String?>> getDirectoriesPaths({ |
There was a problem hiding this comment.
Can you review this? @eugerossetto made a change to the method in platform_interface.
I think this should be the actual implementation:
Future<List<String>?> getDirectoriesPaths({
String? initialDirectory,
String? confirmButtonText,
}) async {
return _channel.invokeListMethod<String>(
'getDirectoriesPaths',
<String, dynamic>{
'initialDirectory': initialDirectory,
'confirmButtonText': confirmButtonText,
'multiple': true,
},
);
}
adpinola
reviewed
Oct 14, 2022
packages/file_selector/file_selector_macos/macos/Classes/FileSelectorPlugin.swift
Show resolved
Hide resolved
VanesaOshiro
force-pushed
the
66978-add-get-multiple-directories-in-macos
branch
4 times, most recently
from
c996a7a to
50b7a3b
Compare
VanesaOshiro
force-pushed
the
66978-add-get-multiple-directories-in-macos
branch
from
50b7a3b to
843a89f
Compare
|
Closing this in favor of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the macOS implementation for retrieving multiple directories paths from a select folder dialog.
Issue: flutter/flutter#74323