Prefer local --resolve entries over --http fetching - #858
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR makes local
--http was enabled, while supplied local schemas are given the first opportunity to satisfy meta-schema resolution.
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/validate/fail_resolve_duplicate_embedded_identifier.clitest">
<violation number="1" location="test/validate/fail_resolve_duplicate_embedded_identifier.clitest:39">
P2: This test expects `Schema identifier already exists`, but these differing embedded schemas take the resolver's `SchemaIdentifierConflictError` path, which reports `Conflicting schemas for the same identifier` plus both resource locations. Update both the text and JSON expectations to match the established conflict diagnostic.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| REPLACE $CWD WITH '[CWD]' IN result_0.txt | ||
|
|
||
| WRITE expected_0.txt UNTIL EOF | ||
| 2> error: Schema identifier already exists |
There was a problem hiding this comment.
P2: This test expects Schema identifier already exists, but these differing embedded schemas take the resolver's SchemaIdentifierConflictError path, which reports Conflicting schemas for the same identifier plus both resource locations. Update both the text and JSON expectations to match the established conflict diagnostic.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At test/validate/fail_resolve_duplicate_embedded_identifier.clitest, line 39:
<comment>This test expects `Schema identifier already exists`, but these differing embedded schemas take the resolver's `SchemaIdentifierConflictError` path, which reports `Conflicting schemas for the same identifier` plus both resource locations. Update both the text and JSON expectations to match the established conflict diagnostic.</comment>
<file context>
@@ -0,0 +1,59 @@
+REPLACE $CWD WITH '[CWD]' IN result_0.txt
+
+WRITE expected_0.txt UNTIL EOF
+2> error: Schema identifier already exists
+2> at identifier https://example.com/duplicate
+2> at file path [CWD]/duplicate.json
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com