Skip to content

Support --continue/-c in the metaschema command - #855

Merged
jviotti merged 2 commits into
mainfrom
metaschema-continue
Sep 7, 2026
Merged

jviotti merged 2 commits into
mainfrom
metaschema-continue

Conversation

@jviotti

@jviotti jviotti commented Sep 7, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Sep 7, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR adds --continue/-c support to the metaschema command.

Changes:

  • By default, validation now stops after the first invalid schema and reports that it stopped.
  • With `--continue`, validation processes all input schemas and reports every validation failure.
  • Registers and documents the option, including Bash and Zsh completion support.
  • Adds CLI tests for both stop-on-first-failure and continue-on-error directory workflows.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 11 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="test/metaschema/fail_directory_continue.clitest">

<violation number="1" location="test/metaschema/fail_directory_continue.clitest:18">
P3: These failure tests only assert the human-readable text output. Add a `--json` variant for both the stop and `--continue` paths so the structured JSON output (one `valid` result per validated schema, including the warning on stderr) is also asserted, matching the existing `fail_directory_json.clitest` pattern.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@@ -0,0 +1,35 @@
MAKE DIRECTORY schemas

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: These failure tests only assert the human-readable text output. Add a --json variant for both the stop and --continue paths so the structured JSON output (one valid result per validated schema, including the warning on stderr) is also asserted, matching the existing fail_directory_json.clitest pattern.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At test/metaschema/fail_directory_continue.clitest, line 18:

<comment>These failure tests only assert the human-readable text output. Add a `--json` variant for both the stop and `--continue` paths so the structured JSON output (one `valid` result per validated schema, including the warning on stderr) is also asserted, matching the existing `fail_directory_json.clitest` pattern.</comment>

<file context>
@@ -0,0 +1,35 @@
+EOF
+
+// Validation failure
+RUN metaschema schemas --continue --verbose STDIN /dev/null IN . INTO result_0.txt EXPECTING 2
+
+WRITE expected_0.txt UNTIL EOF
</file context>

Comment thread docs/metaschema.markdown Outdated
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit db6b3f3 into main Sep 7, 2026
16 checks passed
@jviotti
jviotti deleted the metaschema-continue branch September 7, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant