Skip to content

Print a summary line at the end of validate and metaschema runs - #849

Merged
jviotti merged 3 commits into
mainfrom
summary-line
Sep 7, 2026
Merged

jviotti merged 3 commits into
mainfrom
summary-line

Conversation

@jviotti

@jviotti jviotti commented Sep 7, 2026 •

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Sep 7, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR adds end-of-run validation summaries to the validate and metaschema commands.

Changes:

  • Introduces a shared ValidationSummary structure for validated and failed item counts.
  • Adds a shared formatter that prints validated, passed, and failed totals to stderr.
  • Replaces command-wide boolean status tracking with per-item summary accounting.
  • Updates standard validation flows, including directories and multi-document inputs.
  • Updates metaschema validation flows to account for pass/fail totals.
  • Preserves JSON, trace, and benchmark-oriented output modes without appending the text summary.
  • Retains the existing expected-failure exit behavior when any validation fails.
  • Extends CLI integration expectations across validate, metaschema, compile, install, and test command scenarios.
Technical Notes: Summary formatting adds a separator only after diagnostics or verbose/debug output, keeping otherwise-silent successful runs concise.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 194 files

Re-trigger cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="test/ci/pass_validate_fuse.sh">

<violation number="1" location="test/ci/pass_validate_fuse.sh:44">
P3: The verbose "ok:"/"matches" trace lines go through LOG_VERBOSE, but this test redirects only stderr (2> output.txt) and leaves stdout on the terminal. If LOG_VERBOSE ever routes to stdout, those lines are silently dropped from output.txt and the summary assertion drifts out of sync, so the test would pass while missing output. The verbose trace and summary are expected to land in the stderr-only file together; capture both streams (2>&1) so every verbose line is actually asserted, consistent with the test's intent to check that verbose output is exactly the expected content.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread test/ci/pass_validate_fuse.sh
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit e8b8531 into main Sep 7, 2026
16 checks passed
@jviotti
jviotti deleted the summary-line branch September 7, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant