Print a summary line at the end of validate and metaschema runs - #849
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR adds end-of-run validation summaries to the Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/ci/pass_validate_fuse.sh">
<violation number="1" location="test/ci/pass_validate_fuse.sh:44">
P3: The verbose "ok:"/"matches" trace lines go through LOG_VERBOSE, but this test redirects only stderr (2> output.txt) and leaves stdout on the terminal. If LOG_VERBOSE ever routes to stdout, those lines are silently dropped from output.txt and the summary assertion drifts out of sync, so the test would pass while missing output. The verbose trace and summary are expected to land in the stderr-only file together; capture both streams (2>&1) so every verbose line is actually asserted, consistent with the test's intent to check that verbose output is exactly the expected content.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com