Draft
Conversation
trly
changed the title
Tests against currently maintained build tool versions and compatible JDKs Update bundled tools in docker image
chrapkowski-sg
approved these changes
Jan 16, 2026
| case object Scala_LTS extends Scala("3.3.7", noRestrictions) | ||
| case object Scala2_13 extends Scala("2.13.18", noRestrictions) | ||
| case object Scala2_11 extends Scala("2.11.12", noRestrictions) | ||
| case object Scala2_10 extends Scala("2.10.7", noRestrictions) |
Contributor
There was a problem hiding this comment.
Should we have Scala2_10 here, I don't see any usage?
| // See https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html#build-tool-compatibility-table | ||
| case object SBT15 extends SBT("1.5.2", atMostJava(17)) | ||
| case object SBT110 extends SBT("1.10.0", noRestrictions) | ||
| case object SBT112 extends SBT("1.11.7", noRestrictions) |
Contributor
There was a problem hiding this comment.
SBT112 name is confusing here. I think this should be SBT111 if you mean 1.11.7 so either rename STB or use actual 1.12.x version
| echo "${MILL_REPO_URL}/releases" 1>&2 | ||
| false | ||
| fi | ||
| echo "The --mill-version option is no longer supported." 1>&2 |
Contributor
There was a problem hiding this comment.
We may need to shift
| case object Scala211 extends Scala("2.11.9", atMostJava(11)) | ||
| case object Scala3 extends Scala("3.3.3", noRestrictions) | ||
| case object Scala_Next extends Scala("3.7.4", noRestrictions) | ||
| case object Scala_LTS extends Scala("3.3.7", noRestrictions) |
Contributor
There was a problem hiding this comment.
nit: In Java either SCALA_LTS or ScalaLts (optionally ScalaLTS) same for Scala2_13 and so on. But since this code base seems to already use similar convention here and there this is fully optional.
| case object Scala_Next extends Scala("3.7.4", noRestrictions) | ||
| case object Scala_LTS extends Scala("3.3.7", noRestrictions) | ||
| case object Scala2_13 extends Scala("2.13.18", noRestrictions) | ||
| case object Scala2_11 extends Scala("2.11.12", noRestrictions) |
Contributor
There was a problem hiding this comment.
We may need to add restrictions. Scala 2.11 is most likely not compatible with newer JDK. Probably javaBetween(8, 11) is reasonable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Java 25 support to scip-java docker image
Add a skill file to quickly update all available LTS JVM versions in the docker image
Test plan
Ensured the docker image was able to be built locally and tested locally indexing a Java 25 based project