Skip to content

feat(semanticdsb-scip): map and add SymbolInformation.Kind to scip output#703

Closed
JamyDev wants to merge 1 commit intosourcegraph:mainfrom
JamyDev:feat/provider-kind
Closed

feat(semanticdsb-scip): map and add SymbolInformation.Kind to scip output#703
JamyDev wants to merge 1 commit intosourcegraph:mainfrom
JamyDev:feat/provider-kind

Conversation

@JamyDev
Copy link

@JamyDev JamyDev commented May 7, 2024

This change adds the SymbolInformation.Kind property to DocumentSymbols. The following changes were required to make this work:

  1. Updated the SCIP proto to the latest version from sourcegraph/scip (keeping the package the same to avoid a bunch of refactoring)
  2. Added a mapper to go from SemanticDb Kind to Scip Kind and called it during the SymbolInformation builder.

Test plan

There's no real way to validate the DocumentSymbols using the snapshot tests. Any recommendations for how to test this properly are appreciated!

@JamyDev
Copy link
Author

JamyDev commented May 7, 2024

I see that this is a duplicate of #677, will close if favor of that one.

@JamyDev JamyDev closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant