feat(semanticdsb-scip): map and add SymbolInformation.Kind to scip output#703
Closed
JamyDev wants to merge 1 commit intosourcegraph:mainfrom
Closed
feat(semanticdsb-scip): map and add SymbolInformation.Kind to scip output#703JamyDev wants to merge 1 commit intosourcegraph:mainfrom
JamyDev wants to merge 1 commit intosourcegraph:mainfrom
Conversation
Author
|
I see that this is a duplicate of #677, will close if favor of that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the SymbolInformation.Kind property to DocumentSymbols. The following changes were required to make this work:
Test plan
There's no real way to validate the DocumentSymbols using the snapshot tests. Any recommendations for how to test this properly are appreciated!