Conversation
Previously, the benchmarks were crashing because they accessed classes that are shaded. This commit fixes the problem by moving a public member of a shaded class to another class that is not shaded.
Contributor
Author
These tests failed due to a seeming flake. Will restart once CI is done with other jobs |
keynmol
approved these changes
Jul 26, 2023
Contributor
keynmol
left a comment
keynmol
left a comment
There was a problem hiding this comment.
Confirmed that this fixes benchmarks locally.
Will follow up with a simple CI setup in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the benchmarks were crashing because they accessed classes that are shaded. This commit fixes the problem by moving a public member of a shaded class to another class that is not shaded.
Test plan
n/a. We don't test the benchmarks in CI because they are too slow to run.