Merged
Conversation
bobheadxi
approved these changes
Jan 19, 2024
Member
bobheadxi
left a comment
bobheadxi
left a comment
There was a problem hiding this comment.
Makes sense to me, getting the results from a previous Wait seems less than ideal 😂
camdencheek
force-pushed
the
cc/reusable-err-pool
branch
from
1cc14bf to
2cc8518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the pool types that collect results and errors to reset on
Waitso they are reusable once waited on. Previously, if a pool was reused, the returned values ofWait()would contain the aggregated set of all previous uses. This wasn't explicitly a guarantee of the library before, but it does make it operate more likesync.WaitGroupand it's easy to do, so I think it's a positive change.Fixes #128
Stacked on #126