Repository navigation
Prevent webview to overlap other controls - #286
Merged
Merged
Conversation
PiotrKarczmarz
self-requested a review
June 13, 2025 12:25
PiotrKarczmarz
suggested changes
Jun 13, 2025
PiotrKarczmarz
left a comment
PiotrKarczmarz
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Also Home/Enter keys looks like working in the chat.
One thing, let's rollback changes in WebviewController.cs - they aren't connected with upgrading WebView2 version, and place them in another "cleaning" PR.
PiotrKarczmarz
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat uses WebView2, which has always painted itself as the top window enclosing everything underneath. This was a known issue that, after years, was finally resolved by Microsoft (MicrosoftEdge/WebView2Feedback#286). This PR changes WebView2 controls to the latest version that respects z-order in WPF.
Test plan
Try opening another window above the chat window or docking it to the side of the ide and expanding it over the chat. In either case, the window above the chat should not be overlapped by the chat.