notify: support subscriber threshold to prevent broad spamming#18
Merged
notify: support subscriber threshold to prevent broad spamming#18
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff bbd530a...0b58ecc.
|
nicksnyder
approved these changes
Apr 28, 2022
Contributor
nicksnyder
left a comment
nicksnyder
left a comment
There was a problem hiding this comment.
You never need to block on my review here, but giving it anyway because it was easy!
Minor suggestion to make the message clear that notifications are not being sent.
Co-authored-by: Nick Snyder <nick@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new input option
subscriber-thresholdto limit notifying a large number of subscribes in which cases causes more spamming than high signal. This does not change the default behavior (i.e. notify all).A follow up PR will be made to update "sourcegraph/sourcegraph" to set a reasonable threshold.