-
Notifications
You must be signed in to change notification settings - Fork 225
chore(web): Remove cloud plans #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@brendan-kellam your pull request is missing a changelog! |
|
Caution Review failedThe pull request is closed. WalkthroughRemoves NEXT_PUBLIC_SOURCEBOT_CLOUD_ENVIRONMENT and cloud-specific plans/workflows; deletes GCP demo deploy workflows; refactors plan selection to rely on license keys; adds telemetry flags and PII control; updates telemetry/analytics wiring and removes environment-gated UI/behavior. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skipping since this doesn't impact any user facing stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/web/src/app/[domain]/settings/layout.tsx (1)
14-14:⚠️ Potential issue | 🟡 MinorRemove unused import:
envfrom@sourcebot/shared/client.The
envimport on line 14 is no longer used in this file since theNEXT_PUBLIC_SOURCEBOT_CLOUD_ENVIRONMENTcheck was removed.
🧹 Nitpick comments (1)
packages/web/src/app/posthogProvider.tsx (1)
52-86: Re-initialization concern whenisPiiEnabledis added to the dependency array.
posthog.init()is designed to be called once. AddingisPiiEnabledto the dependency array means if it ever changed,init()would be called again. While this won't happen in practice (env vars are static), callingposthog.init()multiple times with different configs (e.g., differentproperty_denylist) may not update the running instance as expected—PostHog typically ignores subsequentinit()calls.In practice this is a non-issue since the env var is static per deployment, but worth being aware of.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This PR deletes some things:
NEXT_PUBLIC_SOURCEBOT_CLOUD_ENVIRONMENTenvironment variablecloud:teamandcloud:demoplansIt also adds
SOURCEBOT_TELEMETRY_PII_COLLECTION_ENABLED(default false) so we can capture higher fidelity telemetry in our cloud environments.Summary by CodeRabbit
New Features
Bug Fixes
Chores