[CI trigger] Test fix for nodejs/node#63162#1
Open
soulee-dev wants to merge 2 commits into
Open
Conversation
Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>
The existing inline `expectWarning` block at the bottom of the file
overwrites the top-of-file registration added by the previous commit,
because `expectWarning` stores expectations keyed by warning name
(`DeprecationWarning`) and the second call replaces the first.
Consolidate both DEP0181 and DEP0206 expectations into the single
top-of-file call and drop the now-redundant inline block. The
`crypto.Hmac('sha256', 'Node')` call earlier in the file already
exercises the constructor-without-`new` path that triggers DEP0181.
soulee-dev
force-pushed
the
pr-63162-ci-fix
branch
from
79726e7 to
dc1a021
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for merge — fork-only PR to exercise CI on the proposed fix for nodejs/node#63162.
This branch contains:
crypto: runtime-deprecate calling Hmac.digest() more than oncecommon.expectWarningconflict intest/parallel/test-crypto-hmac.jsthat was breaking CI on the upstream PR.The goal is to verify that the upstream CI failure (
AssertionError: Unexpected extra warning received: DeprecationWarning: Calling digest() ...) does not reproduce with the proposed fix.