fix: apply core sub-config overrides during startup parsing#2342
Open
drwicid wants to merge 2 commits intosomeengineering:mainfrom
Open
fix: apply core sub-config overrides during startup parsing#2342drwicid wants to merge 2 commits intosomeengineering:mainfrom
drwicid wants to merge 2 commits intosomeengineering:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a split between config presentation and runtime behavior for core sub-config overrides. Fixes #2341
Before this change, startup only merged overrides for
fix.corewhen buildingCoreConfig. That meantfix.core.commandsoverrides could appear inconfigs show, but the CLI still read the unmerged command list and custom commands were not active. The startup parser now resolves overrides by config id and merges bothfix.core.commandsandfix.core.snapshotsbefore parsing the runtime config objects.This PR also keeps the YAML rendering fix for override annotations containing structured list values. That prevents
configs showand config editing paths from failing whencustom_commands.commandscontains object entries.Files Changed
fixcore/fixcore/core_config.pyfix.core.commandsoverrides into the command config before parsingCustomCommandsConfig.fix.core.snapshotsoverrides into the snapshot config before parsingSnapshotsScheduleConfigso startup behavior stays consistent across sub-configs.fixcore/fixcore/__main__.pyfixcore/fixcore/system_start.pyfixcore/fixcore/config/config_handler_service.pyfixcore/tests/fixcore/core_config_test.pyfixcore/tests/fixcore/config/config_handler_service_test.pyTo-Dos
toxsuccessfully.Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.