fix: handle GCP SERVICE_DISABLED responses as expected errors#2340
Open
drwicid wants to merge 1 commit intosomeengineering:mainfrom
Open
fix: handle GCP SERVICE_DISABLED responses as expected errors#2340drwicid wants to merge 1 commit intosomeengineering:mainfrom
drwicid wants to merge 1 commit intosomeengineering:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves GCP error handling for optional service APIs and fixes #2339 .
The shared error handler to extract reasons from the structured
error.detailspayload and recognizesSERVICE_DISABLEDas an expectedPERMISSION_DENIEDcase. It also applies the shared expected-error set to Filestore snapshot collection so disabled APIs do not surface as collector failures.Files Changed
plugins/gcp/fix_plugin_gcp/resources/base.pyplugins/gcp/fix_plugin_gcp/resources/filestore.pyplugins/gcp/test/test_base.pyplugins/gcp/test/test_filestore.pyValidation
toxsuccessfully.