Skip to content

solo key probe fails due in part to fido2.dumps #168

Description

@4gra

Using solo 0.1.1 from pip, with fido2 pinned to 0.9.1 so that basic things work, we still find solo key probe doesn't work:

$ solo key probe SHA256 ./example.file
[...]
    return __callback(*args, **kwargs)
  File "~/lib/python/site-packages/solo/cli/key.py", line 237, in probe
    serialized_command = fido2.cbor.dumps({"subcommand": hash_type, "data": data})
AttributeError: module 'fido2.cbor' has no attribute 'dumps'

Sure enough this hasn't existed since 2019 - dumps has been replaced by encode.

That's just the start of the problems with probe but it's a clear change that must be made to fix the error and keep up with the library.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions