Skip to content

DEV: Assign components props to its owner node #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryansolid merged 2 commits into from
Sep 4, 2022
Merged

DEV: Assign components props to its owner node #1204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2e976d
assign props to component owner node
thetarnav Sep 2, 2022
25de2e5
improve DevComponent types
thetarnav Sep 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/solid/src/reactive/signal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,10 +476,7 @@ export type InitializedResourceOptions<T, S = unknown> = ResourceOptions<T, S> &
initialValue: T;
};

export type ResourceReturn<T, R = unknown> = [
Resource<T>,
ResourceActions<T | undefined, R>
];
export type ResourceReturn<T, R = unknown> = [Resource<T>, ResourceActions<T | undefined, R>];

export type InitializedResourceReturn<T, R = unknown> = [
InitializedResource<T>,
Expand Down Expand Up @@ -1027,22 +1024,28 @@ export function resumeEffects(e: Computation<any>[]) {
e.length = 0;
}

export interface DevComponent<T> extends Memo<JSX.Element> {
props: T;
componentName: string;
}

// Dev
export function devComponent<T>(Comp: (props: T) => JSX.Element, props: T) {
const c: Partial<Memo<JSX.Element, JSX.Element>> = createComputation<JSX.Element, JSX.Element>(
const c = createComputation(
() =>
untrack(() => {
Object.assign(Comp, { [$DEVCOMP]: true });
return Comp(props);
}),
undefined,
true
);
) as DevComponent<T>;
c.props = props;
c.observers = null;
c.observerSlots = null;
c.state = 0;
c.componentName = Comp.name;
updateComputation(c as Memo<JSX.Element>);
updateComputation(c);
return c.tValue !== undefined ? c.tValue : c.value;
}

Expand Down