fix: mypage/mentor UI 정렬 및 Apple 콜백 중복 호출 방지#470
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a770f9157
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (!code || attemptedAppleAuthCodes.has(code)) return; | ||
|
|
||
| attemptedAppleAuthCodes.add(code); |
There was a problem hiding this comment.
Allow retry when Apple auth callback previously failed
The module-level dedupe permanently blocks a given code after the first attempt, because attemptedAppleAuthCodes.has(code) short-circuits all future mounts in the same tab. If the first postAppleAuth call fails (e.g., transient network/server error) and the user returns to the callback URL from history, this effect no longer calls the API or redirects, leaving the spinner page stuck. Please scope deduping to in-flight calls or remove the code from the set on failure so retries remain possible.
Useful? React with 👍 / 👎.
변경 사항
LinkedTextWithIcon) 정렬 및 버튼 속성 정리code재처리 방지를 위해 module-level Set(attemptedAppleAuthCodes) 적용원인/효과
검증
pnpm --filter @solid-connect/web run ci:check통과pnpm --filter @solid-connect/web run ci:check및pnpm --filter @solid-connect/web run build통과