Skip to content

fix: mypage/mentor UI 정렬 및 Apple 콜백 중복 호출 방지#470

Merged
manNomi merged 2 commits intomainfrom
codex/fix-mentor-mypage-ui-clean
Mar 11, 2026
Merged

fix: mypage/mentor UI 정렬 및 Apple 콜백 중복 호출 방지#470
manNomi merged 2 commits intomainfrom
codex/fix-mentor-mypage-ui-clean

Conversation

@manNomi
Copy link
Contributor

@manNomi manNomi commented Mar 11, 2026

변경 사항

  • 마이페이지/멘토 상세 UI 정렬 및 간격 폴리싱 반영
  • 공통 링크 행 컴포넌트(LinkedTextWithIcon) 정렬 및 버튼 속성 정리
  • Apple 로그인 콜백에서 동일 code 재처리 방지를 위해 module-level Set(attemptedAppleAuthCodes) 적용

원인/효과

  • Apple 콜백 페이지에서 effect 재실행 시 같은 인가 코드로 인증 API가 중복 호출될 수 있어, 동일 코드 재호출을 차단했습니다.

검증

  • pre-commit: pnpm --filter @solid-connect/web run ci:check 통과
  • pre-push: pnpm --filter @solid-connect/web run ci:checkpnpm --filter @solid-connect/web run build 통과

@vercel
Copy link

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connection-web Ready Ready Preview, Comment Mar 11, 2026 2:10pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Mar 11, 2026 2:10pm

@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

Warning

Rate limit exceeded

@manNomi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 205fa9b7-b502-4ac5-8a56-35180aaece78

📥 Commits

Reviewing files that changed from the base of the PR and between 3f830ad and 3a770f9.

📒 Files selected for processing (6)
  • apps/web/src/app/community/[boardCode]/[postId]/modify/PostModifyForm.tsx
  • apps/web/src/app/community/[boardCode]/create/PostForm.tsx
  • apps/web/src/app/login/apple/callback/AppleLoginCallbackPage.tsx
  • apps/web/src/app/mentor/[id]/_ui/MentorDetialContent/index.tsx
  • apps/web/src/app/my/_ui/MyProfileContent/index.tsx
  • apps/web/src/components/ui/LinkedTextWithIcon/index.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/fix-mentor-mypage-ui-clean

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the web label Mar 11, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a770f9157

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +17 to +19
if (!code || attemptedAppleAuthCodes.has(code)) return;

attemptedAppleAuthCodes.add(code);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allow retry when Apple auth callback previously failed

The module-level dedupe permanently blocks a given code after the first attempt, because attemptedAppleAuthCodes.has(code) short-circuits all future mounts in the same tab. If the first postAppleAuth call fails (e.g., transient network/server error) and the user returns to the callback URL from history, this effect no longer calls the API or redirects, leaving the spinner page stuck. Please scope deduping to in-flight calls or remove the code from the set on failure so retries remain possible.

Useful? React with 👍 / 👎.

@manNomi manNomi merged commit 8472772 into main Mar 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant