Merged
Conversation
wibaek
approved these changes
Aug 27, 2024
Member
wibaek
left a comment
wibaek
left a comment
There was a problem hiding this comment.
저는 null 일 때만 문제가 될 것이라 생각했는데, 카카오 기본 이미지 일때도 문제가 발생할 수 있겠네요😮
S3Service에서 예외처리를 하는 방식으로도 접근해볼 수 있을 것 같네요.
모두 좋아보입니다 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
특이 사항
기존 프로필 이미지 수정시에는 반드시 기존 파일을 삭제하도록 구현하였으나, 초기 프로필 이미지의경우 S3에 저장되지 않아서 문제가 발생함
따라서 초기 프로필 사진 수정시에는 deleteExProfile를 수행하지 않도록 수정함
리뷰 요구사항 (선택)