CI: Update repo to run CI on imported packages#56
Merged
Conversation
#### Problem The repo has imported many packages from SPL, but they aren't properly integrated, since they can't be built, CI isn't running, etc. #### Summary of changes It's a bit of a suite of changes, but they get the repo up and running with the program and everything! Here are the changes: * update to Solana v2.1 crates and rust toolchain * add new packages to Cargo workspace * update Rust packages to use crates.io versions where applicable * move program-2022-tests into clients/rust-legacy/tests * remove `test-sbf` feature on program-2022-tests * add `[package.metadata.solana.program-id]` for token-2022 and elgamal registry * update JS legacy tests to use validator started with `start-validator.mjs` * add concept of "fixture programs" to load programs from the test fixtures directory during JS legacy tests * make scripts language-specific instead of package-specific, to reuse the JS and rust scripts * remove Token-2022 as a downloaded program, opt for the built version * add package.json entries to run build / test / format / lint for the program / cli / rust-legacy / js-legacy / confidential transfer * execute the new steps in CI
samkim-crypto
approved these changes
Jan 10, 2025
lorisleiva
approved these changes
Jan 10, 2025
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Amazing! I love seeing a repo structure being pushed to the limit. 💪
Comment on lines
+37
to
+43
| "confidential-transfer:proof-extraction:format": "zx ./scripts/rust/format.mjs confidential-transfer/proof-extraction", | ||
| "confidential-transfer:proof-extraction:lint": "zx ./scripts/rust/lint.mjs confidential-transfer/proof-extraction", | ||
| "confidential-transfer:proof-generation:format": "zx ./scripts/rust/format.mjs confidential-transfer/proof-generation", | ||
| "confidential-transfer:proof-generation:lint": "zx ./scripts/rust/lint.mjs confidential-transfer/proof-generation", | ||
| "confidential-transfer:proof-tests:test": "zx ./scripts/rust/test.mjs confidential-transfer/proof-tests", | ||
| "confidential-transfer:proof-tests:format": "zx ./scripts/rust/format.mjs confidential-transfer/proof-tests", | ||
| "confidential-transfer:proof-tests:lint": "zx ./scripts/rust/lint.mjs confidential-transfer/proof-tests", |
joncinque
added a commit
to joncinque/token-group
that referenced
this pull request
Feb 27, 2025
#### Problem The repo has all the code from SPL, but was never updated to actually work outside of SPL. #### Summary of changes Similar to solana-program/token-2022#56, with a few extras: * add scripts * add package.json for the repo * update JS client to run prettier * change JS client to build to "dist" instead of "lib" for consistency * use packages from crates.io * update repo / homepage / authors in packages * fix spellcheck errors * add CI to exercise almost all scripts
joncinque
added a commit
to solana-program/token-group
that referenced
this pull request
Mar 6, 2025
* CI: Bring repo up to date with CI #### Problem The repo has all the code from SPL, but was never updated to actually work outside of SPL. #### Summary of changes Similar to solana-program/token-2022#56, with a few extras: * add scripts * add package.json for the repo * update JS client to run prettier * change JS client to build to "dist" instead of "lib" for consistency * use packages from crates.io * update repo / homepage / authors in packages * fix spellcheck errors * add CI to exercise almost all scripts * TEMP: Run CI on all branches for testing * Disable semver job temporarily * Update Solana deps * Install more deps for program testing * Test JS client without built program * Revert all branches running CI * Run everything in parallel * Update package publish to a choice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repo has imported many packages from SPL, but they aren't properly integrated, since they can't be built, CI isn't running, etc.
Summary of changes
It's a bit of a suite of changes, but they get the repo up and running with the program and everything! Here are the changes:
test-sbffeature on program-2022-tests[package.metadata.solana.program-id]for token-2022 and elgamal registrystart-validator.mjsSuccessful run at https://github.com/joncinque/token-2022/actions/runs/12691995000