Skip to content

Add toml cli to runner#1173

Closed
grod220 wants to merge 1 commit into
mainfrom
toml-cli-install
Closed

Add toml cli to runner#1173
grod220 wants to merge 1 commit into
mainfrom
toml-cli-install

Conversation

@grod220
Copy link
Copy Markdown
Member

@grod220 grod220 commented May 14, 2026

Addresses build failures. Context: #1162 (comment).

@joncinque
Copy link
Copy Markdown
Contributor

Can we do this at an even lower level, at https://github.com/solana-program/actions/blob/main/setup-ubuntu/action.yml ?

@grod220
Copy link
Copy Markdown
Member Author

grod220 commented May 14, 2026

@joncinque we could but it would require adding the setup action on the set_env step. If we are cool with that, maybe we should add it as a flag like so?

jobs:
  set_env:
    name: Set variables to be used in strategy definitions in reusable workflow
    runs-on: ubuntu-latest
    outputs:
      JS_PACKAGES: ${{ steps.compute.outputs.JS_PACKAGES }}
      SBPF_PROGRAM_PACKAGES: ${{ steps.compute.outputs.SBPF_PROGRAM_PACKAGES }}
      ...
    steps:
      - name: Git Checkout
        uses: actions/checkout@v4

-     - name: Install toml-cli
-       uses: taiki-e/install-action@v2
-       with:
-         tool: toml-cli

+     - name: Setup Environment
+       uses: solana-program/actions/setup-ubuntu@main
+.        toml-cli: true

      - name: Compute variables
        id: compute
        shell: bash
        run: |
          echo "JS_PACKAGES=${{ env.JS_PACKAGES }}" >> $GITHUB_OUTPUT
          echo "SBPF_PROGRAM_PACKAGES=${{ env.SBPF_PROGRAM_PACKAGES }}" >> $GITHUB_OUTPUT
          ...

@joncinque
Copy link
Copy Markdown
Contributor

We can add a flag to that action, or even simpler, just install it unconditionally in that action. I'd go with the second option, since it'll be simple -- what do you think?

@grod220
Copy link
Copy Markdown
Member Author

grod220 commented May 14, 2026

Replaced by solana-program/actions#34

@grod220 grod220 closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants