program: do not resize self-split, ban self-withdraw#96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the account realloc added in #82 did not properly handle the case for
SplitandWithdrawwhere the source is the same account as the destination, therefore truncating an uninitialized "source" incorrectly truncated the destinationthis pr makes it so we do not truncate for self-split, and we ban self-withdraws entirely. i decided to do this instead of handling the withdraw case because there are existing tests ensuring self-split is possible but no such tests for self-withdraw. in any event philosophically withdraw should have as few features as is practical
Mergealso resizes source to zero, but self-merge is already banned