Skip to content

Option to specify wasm-toolchain#16

Merged
grod220 merged 2 commits into
mainfrom
wasm-nightly-toolchain
Oct 14, 2025
Merged

Option to specify wasm-toolchain#16
grod220 merged 2 commits into
mainfrom
wasm-nightly-toolchain

Conversation

@grod220
Copy link
Copy Markdown
Member

@grod220 grod220 commented Oct 13, 2025

Some repos require the use of nightly to be able to build wasm binaries.

This PR introduces a new input var that allows consumers to specify the toolchain for that CI/CD job. The ergonomics are a bit different than the others given it requires two steps: 1) installing the right toolchain and 2) installing a target.

@joncinque
Copy link
Copy Markdown
Contributor

Do they actually require nightly? I just tried compiling the interface and program crates with the stable toolchain, and it worked fine

@joncinque
Copy link
Copy Markdown
Contributor

Ah --all-features, screwed over by frozen-abi again

@grod220
Copy link
Copy Markdown
Member Author

grod220 commented Oct 13, 2025

Ah --all-features, screwed over by frozen-abi again

Yes, that's it indeed 😢

Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very slick! Just the bit about calling make build-wasm...

Comment thread .github/workflows/main.yml
@grod220 grod220 requested a review from joncinque October 14, 2025 07:59
@grod220
Copy link
Copy Markdown
Member Author

grod220 commented Oct 14, 2025

Also, think it would be helpful to make a push a git tag after this. I noticed a few repos depending on @main which may cause us pain down the line if we want to make a breaking change.

Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! And feel free to push a tag if you want, but I'd only use it in downstream repos if necessary.

This repo is for internal consumption, so we don't need to prioritize stability at the cost of development speed by forcing repos to individually upgrade all the time.

@grod220
Copy link
Copy Markdown
Member Author

grod220 commented Oct 14, 2025

True, that's fair. Helpful context 👍

@grod220 grod220 merged commit 3823505 into main Oct 14, 2025
@grod220 grod220 deleted the wasm-nightly-toolchain branch October 14, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants