Option to specify wasm-toolchain#16
Conversation
|
Do they actually require nightly? I just tried compiling the interface and program crates with the stable toolchain, and it worked fine |
|
Ah |
Yes, that's it indeed 😢 |
joncinque
left a comment
There was a problem hiding this comment.
Very slick! Just the bit about calling make build-wasm...
|
Also, think it would be helpful to make a push a git tag after this. I noticed a few repos depending on |
joncinque
left a comment
There was a problem hiding this comment.
Looks great! And feel free to push a tag if you want, but I'd only use it in downstream repos if necessary.
This repo is for internal consumption, so we don't need to prioritize stability at the cost of development speed by forcing repos to individually upgrade all the time.
|
True, that's fair. Helpful context 👍 |
Some repos require the use of nightly to be able to build wasm binaries.
This PR introduces a new input var that allows consumers to specify the toolchain for that CI/CD job. The ergonomics are a bit different than the others given it requires two steps: 1) installing the right toolchain and 2) installing a target.