Add web example - #1717
Merged
Merged
Add web example#1717
Conversation
4 tasks
WoLewicki
reviewed
Mar 4, 2022
WoLewicki
left a comment
Member
There was a problem hiding this comment.
I added some comments, please answer them and I think we can merge it then. Thanks for your contribution 🎉
91 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following #1294
I tried to keep the changes as minimal as possible, but I had to:
gradlefrom.gitignore(not supposed to be here)jsxBracketSameLineuntilprettieris updated (the current version does not support it, it clashes withprettier-eslintand it's impossible to work)Modal(now included inreact-native-web)getHasTouchablePropertyto the web implem (it's only used here) + removeanySnackImageCompat(doesn't work at all, use inheritance other composition, results in aSuper expression must either be null or a functionerror)And as mentioned in the original PR:
PanResponderexample does not work:Screen.Recording.2022-03-04.at.13.20.25.mov
Checklist
README.md__tests__folder