Skip to content

fix(parse): fix issue on trying to parse invalid XML - #1476

Closed
uqmessias wants to merge 2 commits into
software-mansion:developfrom
uqmessias:develop
Closed

uqmessias wants to merge 2 commits into
software-mansion:developfrom
uqmessias:develop

Conversation

@uqmessias

Copy link
Copy Markdown
Contributor

Summary

It finally fixes #1105, the parser throws an error when trying to parse an invalid SVG file, but instead of throwing an error, it should call onError prop (if it was set) and let it handle the error.

Test Plan

It was tested on this repo: https://github.com/vinitgundeti/reactnativesvg

rn-svg-fixes-onerror-handler

Thanks @vinitgundeti, for taking the time to uploading it.

Compatibility

OS Implemented
iOS ✅
Android ✅

@uqmessias uqmessias mentioned this pull request Oct 16, 2020
@vinitgundeti

Copy link
Copy Markdown

@uqmessias Thank you very much for fixing this, this was must required feature, i have tested it and it is working fine. when will this be in the main branch ?

@halilb

halilb commented Oct 23, 2020

Copy link
Copy Markdown

Thanks for the fix @uqmessias. I wasn't able to add your branch as dependency because of typescript exceptions. I fixed them and created uqmessias#1 into your branch.

@uqmessias

Copy link
Copy Markdown
Contributor Author

Thanks @halilb, I merged your PR into mine and made some changes. Could you test it again, please?

@halilb

halilb commented Nov 2, 2020

Copy link
Copy Markdown

Thanks @halilb, I merged your PR into mine and made some changes. Could you test it again, please?

That's working fine for me. Thank you @uqmessias!

@WoLewicki

Copy link
Copy Markdown
Member

@uqmessias since #1503 and #1718 have been merged, do you think we can close it?

@uqmessias

Copy link
Copy Markdown
Contributor Author

@uqmessias since #1503 and #1718 have been merged, do you think we can close it?

👍🏽

@uqmessias uqmessias closed this Jul 8, 2022
@uqmessias
uqmessias deleted the develop branch July 8, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SvgUri On Error

4 participants