Conversation
Closed
|
@uqmessias Thank you very much for fixing this, this was must required feature, i have tested it and it is working fine. when will this be in the main branch ? |
|
Thanks for the fix @uqmessias. I wasn't able to add your branch as dependency because of typescript exceptions. I fixed them and created uqmessias#1 into your branch. |
Based on PR #1
Contributor
Author
|
Thanks @halilb, I merged your PR into mine and made some changes. Could you test it again, please? |
That's working fine for me. Thank you @uqmessias! |
Member
|
@uqmessias since #1503 and #1718 have been merged, do you think we can close it? |
Contributor
Author
👍🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It finally fixes #1105, the parser throws an error when trying to parse an invalid
SVGfile, but instead of throwing an error, it should callonErrorprop (if it was set) and let it handle the error.Test Plan
It was tested on this repo: https://github.com/vinitgundeti/reactnativesvg
Thanks @vinitgundeti, for taking the time to uploading it.
Compatibility