Repository navigation
Conversation
The bottom-margin line between two code blocks in a list item or a quote was skipped without closing the open code block, so both blocks were exported as one <pre>. Close it before skipping the line.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Stacked on #1065. In the HTML export, two code blocks in a row inside a list item or a quote came out as a single
<pre>:#1065 skips the empty bottom-margin line a code block leaves inside a list item or a quote, so it doesn't export an empty
<li>or<p>. That line used to close the open code block, so after the skip the next block's lines were appended to the same<pre>. The code block is now closed before the line is skipped, as Copilot suggested in #1065 (comment).Testing
New Robolectric test
ListChildrenExportTest.keepsConsecutiveCodeBlocksApartInHtml, covering the list item and quote cases. It fails without the fix../gradlew :ui:testDebugUnitTestand./gradlew ktlintCheckpass.PR Checklist