Repository navigation
Conversation
Port of the marker part of the React Native fix for list items with block children (#478). An item that opens with a code block or a sublist had no marker of its own (`- - nested` lost the outer bullet). A ListMarkerAnchorSpan on the item's first character now draws the marker in the gutter, from the x Layout passes it, so inside a blockquote it sits past the quote bar. Tapping that line toggles a task through the anchor's marker, and accessibility announces it as the item's start. Every segment of such an item now skips the marker, so copy-as-markdown no longer tracks which item a code block opened.
2 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Stacked on #1065.
Testing
Example markdown:
PR Checklist