Add explicit getter and setter for datas#509
Merged
bakpaul merged 2 commits intosofa-framework:masterfrom Jul 10, 2025
Merged
Conversation
fredroy
approved these changes
Jul 9, 2025
7c4d108 to
90b37bf
Compare
hugtalbot
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Add explicit getter and setter * Remove mistake
Contributor
|
Well, I would maybe have argued not to merge that one.
Wouldn't adding a filter on setattr so that the setting of the value is only done when when the name of the attribute is "value" and falling back to default python behavior for other attr the expected behavior ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds explicit methods to get or set data values as done in C++. This is required for me in a project using RPyC.
I really think the current mechanism of false attribute 'value' being in the meantime a getter and somehow a setter (which by the way doesn't require to really use
XX.value = smthbut any attribute unknown by the data will work. This is all confusing for the user.