Handle interrupted io_uring process waits - #215
Merged
Merged
Conversation
samuel-williams-shopify
force-pushed
the
fix-process-wait-spurious-resume
branch
from
August 26, 2026 08:40
ed699e0 to
20b2e4e
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
falsewhenprocess_waitis resumed before process completionwaitidoperations before stack-backedsiginfogoes out of scopefalsewhen cancellation wins, or preserve the real process status whenwaitidwins the cancellation raceKQueue, EPoll, and legacy pidfd-based io_uring waits already return
falseon a normal interruption. This makes modern io_uringwaitidconsistent without imposing retry policy on io-event; higher-level schedulers such as Async can decide whether to retry.Testing
BUNDLE_GEMFILE=gems.rb bundle exec bake buildBUNDLE_GEMFILE=gems.rb bundle exec bake test(292 passed, 17 skipped; 911 assertions)