Skip to content

stop using readable-stream#107

Merged
smhg merged 1 commit intosmhg:masterfrom
pirxpilot:remove-readable-stream
Dec 26, 2025
Merged

stop using readable-stream#107
smhg merged 1 commit intosmhg:masterfrom
pirxpilot:remove-readable-stream

Conversation

@pirxpilot
Copy link
Copy Markdown
Contributor

readable-stream is only needed to support node < 18
as documented in package.json we expect node >= 18

Copilot AI review requested due to automatic review settings December 25, 2025 20:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the readable-stream dependency, which was only needed to support Node.js versions prior to 18. Since the project requires Node.js >= 18 (as specified in package.json), the built-in stream module can be used directly instead.

  • Removed readable-stream from package dependencies
  • Updated imports and type references to use Node.js built-in stream module

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Removed the readable-stream dependency from the dependencies list
lib/poparser.js Updated import statement from readable-stream to stream and updated JSDoc type references to use node:stream

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/poparser.js Outdated
@pirxpilot pirxpilot force-pushed the remove-readable-stream branch from 7c180a3 to 6783634 Compare December 26, 2025 01:58
`readable-stream` is only needed to support node < 18
as documented in `package.json` we expect node >= 18
@pirxpilot pirxpilot force-pushed the remove-readable-stream branch from 6783634 to b5e2182 Compare December 26, 2025 15:01
@smhg smhg merged commit bd70381 into smhg:master Dec 26, 2025
6 checks passed
@pirxpilot pirxpilot deleted the remove-readable-stream branch December 26, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants