Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the readable-stream dependency, which was only needed to support Node.js versions prior to 18. Since the project requires Node.js >= 18 (as specified in package.json), the built-in stream module can be used directly instead.
- Removed
readable-streamfrom package dependencies - Updated imports and type references to use Node.js built-in
streammodule
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Removed the readable-stream dependency from the dependencies list |
| lib/poparser.js | Updated import statement from readable-stream to stream and updated JSDoc type references to use node:stream |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7c180a3 to
6783634
Compare
`readable-stream` is only needed to support node < 18 as documented in `package.json` we expect node >= 18
6783634 to
b5e2182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readable-streamis only needed to support node < 18as documented in
package.jsonwe expect node >= 18