4.x - Add route context helper#2759
Conversation
|
Looks good, althoug I have to check in more depth. Could you please add the slim file header comment to the two new files? |
|
In |
|
@adriansuter and do what? Throw an exception? PHP will already throw a |
|
@shadowhand we need to throw an exception to notify the user that routing hasn't been performed if those attributes are null. Probably throw a |
|
Or an But then, a call to this static method has to be wrapped into a try-catch block. Probably it is better to throw a |
|
@l0gicgate @adriansuter updated with your requested changes. |
adriansuter
left a comment
There was a problem hiding this comment.
Some imports can be removed.
l0gicgate
left a comment
There was a problem hiding this comment.
Looks good to me @adriansuter can you review one last time before I merge please?
|
Thanks - everything is fine. |
|
We should not forget to update the docs about this new feature. |
|
@adriansuter absolutely |
Add route context helper
Creates a new
RouteContextclass that can be used to gain access to the current request route, route parser, and routing results.Fixes #2758
Fixes #2761