Skip to content

fixes wrong number of parameters passed to handler in ErrorMiddleware::handleException function#2565

Closed
lordrhodos wants to merge 4 commits into
slimphp:4.xfrom
lordrhodos:feature/fix-middlware-closure-parameters
Closed

fixes wrong number of parameters passed to handler in ErrorMiddleware::handleException function#2565
lordrhodos wants to merge 4 commits into
slimphp:4.xfrom
lordrhodos:feature/fix-middlware-closure-parameters

Conversation

@lordrhodos

Copy link
Copy Markdown

This PR adds the $response object to the parameters passed to the attached handler and updates related phpdocs

closes #2564

@coveralls

coveralls commented Jan 11, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.004%) to 97.409% when pulling 42bd5a5 on lordrhodos:feature/fix-middlware-closure-parameters into bcf7df5 on slimphp:4.x.

@akrabat akrabat added the Slim 4 label Jan 15, 2019
@l0gicgate

Copy link
Copy Markdown
Member

See comments on #2564.

@lordrhodos

lordrhodos commented Jan 22, 2019

Copy link
Copy Markdown
Author

@l0gicgate should this be closed or should it stay open until #2555 is merged?

@l0gicgate

Copy link
Copy Markdown
Member

This can be closed, we're going to merge #2555 before end of week here hopefully. Thank you for contributing!

@lordrhodos lordrhodos closed this Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants